Re: [Xen-devel] [PATCH] VMX: PLATFORM_INFO MSR is r/o

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.09.17 at 19:05, <roger.pau@xxxxxxxxxx> wrote:
> On Fri, Sep 22, 2017 at 03:07:44AM -0600, Jan Beulich wrote:
>> Therefore all write attempts should produce #GP, just like on real
>> hardware.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -3138,10 +3138,7 @@ static int vmx_msr_write_intercept(unsig
>>          break;
>>  
>>      case MSR_INTEL_PLATFORM_INFO:
>> -        if ( msr_content ||
>> -             rdmsr_safe(MSR_INTEL_PLATFORM_INFO, msr_content) )
>> -            goto gp_fault;
>> -        break;
>> +        goto gp_fault;
> 
> Could you place the label together with the MSR_IA32_FEATURE_CONTROL
> one above? So that we don't add another case with just a gp_fault.

Oh, of course. I did think I had looked for something to group
it with, but clearly I hadn't (maybe that was the PV side change
then).

> With that:
> 
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel