Re: [Xen-devel] [PATCH v4 10/13] xen/pvcalls: implement recvmsg

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

>  
> +static bool pvcalls_front_read_todo(struct sock_mapping *map)
> +{
> +     struct pvcalls_data_intf *intf = map->active.ring;
> +     RING_IDX cons, prod;
> +     int32_t error;
> +
> +     cons = intf->in_cons;
> +     prod = intf->in_prod;
> +     error = intf->in_error;
> +     return (error != 0 ||
> +             pvcalls_queued(prod, cons,
> +                            XEN_FLEX_RING_SIZE(PVCALLS_RING_ORDER)) != 0);


Does this routine have to be different from pvcalls_front_write_todo()?
They look pretty similar. Can they be merged?

(and you don't really need 'error' variable)

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel