Re: [Xen-devel] [PATCH v2 02/21] libxl: introduce a way to mark fields as deprecated in the idl

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monné writes ("Re: [PATCH v2 02/21] libxl: introduce a way to mark 
fields as deprecated in the idl"):
> Thanks for the review. I've fixed all the other comments on the series
> and started an osstest flight, my aim is to post a new version of the
> series using the same deprecation idl mechanism ASAP.

I'll look forward to it.

> The motivation for doing this is that I think we really need stable
> PVHv2 support in Xen, and it must be in the next release.

I agree.


> Regarding your proposal for deprecating fields, I was thinking of
> something along the lines of:
> 
> deprecated_fields=[['u.hvm.timer_mode', 'timer_mode'],
>                    ['u.pv.bootloader', 'booloader'],
>                    ...]

That looks fairly nice, yes.

> Something like a list of tuples (I'm not sure this is the right
> terminology in python?), where the first element is the deprecated
> field, and the second one is the new position.
> 
> This has the extra complication that when parsing the types gentypes
> needs to split the strings based on the '.' or '->' delimiters, and
> then iterate inside of the structure object to find the actual
> element. AFAICT this is doable, but not as simple as my current
> approach.

Indeed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel