[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v9 01/10] xen: add function for obtaining highest possible memory address

>>> On 22.09.17 at 13:41, <jgross@xxxxxxxx> wrote:
> @@ -104,6 +104,8 @@ struct xen_sysctl_physinfo {
>      /* XEN_SYSCTL_PHYSCAP_??? */
>      uint32_t capabilities;
> +
> +    uint64_t max_mfn;     /* Largest possible MFN on this host */
>  };

I'm sorry for not having noticed this earlier - this needs to be
uint64_aligned_t and creates an unnamed padding hole (yes,
there already is another one, but anyway). So I think this also
wants moving up to avoid creating yet another hole. I think
this is doable while committing (and if I end up doing it I'll likely
take the opportunity and move "capabilities" up into the earlier
hole at the same time). With that adjustment
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.