Re: [Xen-devel] [PATCH v4 05/11] alternative/x86/arm32: Align altinstructions (and altinstr_replacement) sections.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.09.17 at 00:31, <konrad@xxxxxxxxxx> wrote:
> @@ -73,6 +75,7 @@ int apply_alternatives(const struct alt_instr *start, const 
> struct alt_instr *en
>  #include <asm/asm_defns.h>
>  
>  .macro altinstruction_entry orig_offset alt_offset feature orig_len alt_len
> +     .p2align 2
>       .word \orig_offset - .
>       .word \alt_offset - .
>       .hword \feature
> @@ -103,6 +106,7 @@ int apply_alternatives(const struct alt_instr *start, 
> const struct alt_instr *en
>  .macro alternative_if_not cap, enable = 1
>       .if \enable
>       .pushsection .altinstructions, "a"
> +     .p2align 2
>       altinstruction_entry 661f, 663f, \cap, 662f-661f, 664f-663f
>       .popsection

Why? altinstruction_entry already does what you want.

x86 parts
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel