Re: [Xen-devel] [PATCH v2 02/21] libxl: introduce a way to mark fields as deprecated in the idl

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH v2 02/21] libxl: introduce a way to mark fields as 
deprecated in the idl"):
> On Wed, Sep 20, 2017 at 04:46:16PM +0100, Ian Jackson wrote:
...
> > We discussed how this might be done better.  To me it seems like the
> > only really plausible alternative was to replace the
> > `deprecated_by' and `copy_deprecated_fn' annotations with a single
> > annotation in the parent structure, something like
> >   deprecated_fields=['u.hvm','u',['bootloader_args',
> >                                   'timer_mode', ...]
> > or maybe even
> >   deprecated_fields=['u.hvm','u',[('timer_mode_new_name','timer_mode')]]
> 
> I know this may sound crazy but: do we need to consider the possibility
> that one field in struct A is deprecated by one field in struct B?

I don't think we can rule that out.  My proposed "deprecated_fields"
thing would be able to cope with that: the information about which
field to copy where is in the struct(s) that contain both A and B.

But, as I say, I don't want to insist on a more comprehensive solution
at this stage.  The IDL compiler language is not a stable interface so
we could choose to do this rework later, when the need arises.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel