Re: [Xen-devel] [PATCH v2 17/24] xen/arm: page: Clean-up the definition of MAIRVAL

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 20/09/2017 22:03, Stefano Stabellini wrote:
> On Wed, 20 Sep 2017, Julien Grall wrote:
> > Hi,
> >
> > On 20/09/17 00:51, Stefano Stabellini wrote:
> > > On Tue, 12 Sep 2017, Julien Grall wrote:
> > > > Currently MAIRVAL is defined in term of MAIR0VAL and MAIR1VAL which are
> > > > both hardcoded value. This makes quite difficult to understand the value
> > > > written in both registers.
> > > >
> > > > Rework the definition by using value of each attribute shifted by their
> > > > associated index.
> > > >
> > > > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > > Ah! That's why you haven't properly updated MAIR0VAL and MAIR1VAL in the
> > > previous patches. In that case, please say explicitly in the commit
> > > messages of those patches that MAIR0VAL and MAIR1VAL will be properly
> > > update in a follow-up patch.
> > I didn't need to update MAIR0VAL and MAIR1VAL because the remove attributes
> > were just alias. Not because I was modifying the 2 defines here.
> I thought their AIs were unique, but no, even the AIs are aliases. You
> are right. In that case, I'll add my reviewed-by to them.
I guess it because it is copied from ARMv7 Linux which also use aliases. 
But I think they are more confusing than really helpful.
Thank you for the reviewed-by.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel