Re: [Xen-devel] [PATCH 22/22] RFC: tools: xentoolcore_restrict_all: use domid_t

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Sep 19, 2017 at 12:01:15PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH 22/22] RFC: tools: xentoolcore_restrict_all: use 
> domid_t"):
> > On Fri, Sep 15, 2017 at 07:48:59PM +0100, Ian Jackson wrote:
> > > This is an RFC because it does not currently compile, because not all
> > > the places that use xentoolcore have a definition of domid in scope!
> ...
> > If the places you mentioned are in xen.git we should probably fix them.
> > If they are external users like QEMU then we probably can't do much.
> 
> They are in xen.git.  The difficulty is that they don't currently
> include the right headers.  Also, in general, much of the code in
> xen.git doesn't always use domid_t.
> 
> (Partly because domid_t is a weird short type.)

I would very much like to have domid_t in the toolcore API, just to be
consistent with xendevicemodel APIs. I think we should fix xen.git --
including the right header in the places which use toolcore APIs doesn't
sound too hard for me.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel