Re: [Xen-devel] [PATCH v2 04/21] xl: introduce a domain type option

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v2 04/21] xl: introduce a domain type option"):
> Introduce a new type option to xl configuration files in order to
> specify the domain type. This supersedes the current builder option.
...> 
> Th
>      libxl_defbool_set(&c_info->run_hotplug_scripts, run_hotplug_scripts);
>      c_info->type = LIBXL_DOMAIN_TYPE_PV;
> -    if (!xlu_cfg_get_string (config, "builder", &buf, 0) &&
> -        !strncmp(buf, "hvm", strlen(buf)))
> -        c_info->type = LIBXL_DOMAIN_TYPE_HVM;
> +    if (!xlu_cfg_get_string (config, "builder", &buf, 0)) {
> +        fprintf(stderr,
> +                "The builder option is being deprecated, please use type 
> instead.\n");

Line length.  Probably best to shuffle the message to the left, rather
than linewrapping, for ease of grepping.

The error message would benefit from some `quotes' around the
parameter names.

It would be nice if you did this in a way that meant that a config
file which specified both `type="hvm"' and `builder="hvm"' did not
generate a warning.

And it ought to be an error to specify `type="pv"' with
`builder="hvm"' surely.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel