[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] xen: grant-table: Simplify get_paged_frame


On 19/09/17 09:56, Jan Beulich wrote:
On 19.09.17 at 10:34, <Paul.Durrant@xxxxxxxxxx> wrote:
I do wonder whether this function belongs in the grant table code though.
Getting the page from a (d, gfn) tuple is probably something that's needed in
a few places and hence putting the code in common/memory.c (with suitable
adjustment to the error values) would seem more appropriate.

That's been true from the very beginning of the existence of
the function, I think.

I am not sure how this function would fit in common/memory.c code. We already have get_page_from_gfn to get a page from the tuple (d, gfn).

This function adds more check that may not fit everyone. The only place I could see potential usage is prepare_ring_for_helper. But what would be a suitable name given?


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.