Re: [Xen-devel] [PATCH] mm: Scrub pages returned back to heap if MEMF_no_scrub is set

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 15, 2017 at 10:05:22AM -0600, Jan Beulich wrote:
> >>> On 15.09.17 at 16:04, <boris.ostrovsky@xxxxxxxxxx> wrote:
> > Set free_heap_pages()'s need_scrub to true if alloc_domheap_pages()
> > returns pages back to heap as result of assign_pages() error when those
> > pages were requested with MEMF_no_scrub flag.
> > 
> > We need to do this because there is a possibility that
> > alloc_heap_pages() might clear buddy's PGC_need_scrubs flag without
> > actually clearing the page.
> > 
> > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > ---
> > We are declaring a likely clean (or almost clean) chunk to be dirty. Since
> > this only happend on assign_pages() error I figured it would be acceptable.
> 
> I think that's fine, but let's wait a little to see whether others
> have differing opinions.
> 

I think that's fine, too.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel