Re: [Xen-devel] [PATCH 06/12] arm/alternative.c: switch to plain bool

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 09/15/2017 10:42 AM, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

> ---
>   xen/arch/arm/alternative.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c
> index a3bcda3117..9ffdc475d6 100644
> --- a/xen/arch/arm/alternative.c
> +++ b/xen/arch/arm/alternative.c
> @@ -46,17 +46,17 @@ struct alt_region {
>   /*
>    * Check if the target PC is within an alternative block.
>    */
> -static bool_t branch_insn_requires_update(const struct alt_instr *alt,
> -                                          unsigned long pc)
> +static bool branch_insn_requires_update(const struct alt_instr *alt,
> +                                        unsigned long pc)
>   {
>       unsigned long replptr;
>   
>       if ( is_active_kernel_text(pc) )
> -        return 1;
> +        return true;
>   
>       replptr = (unsigned long)ALT_REPL_PTR(alt);
>       if ( pc >= replptr && pc <= (replptr + alt->alt_len) )
> -        return 0;
> +        return false;
>   
>       /*
>        * Branching into *another* alternate sequence is doomed, and
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel