[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/libxc/xc_dom_arm: add missing variable initialization



On Mon, Aug 21, 2017 at 1:20 AM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Sat, Aug 19, 2017 at 04:21:42PM +0200, Thomas Petazzoni wrote:
>> From: Bernd Kuhls <bernd.kuhls@xxxxxxxxxxx>
>>
>> The variable domctl.u.address_size.size may remain uninitialized if
>> guest_type is not one of xen-3.0-aarch64 or xen-3.0-armv7l. And the
>> code precisely checks if this variable is still 0 to decide if the
>> guest type is supported or not.
>>
>> This fixes the following build failure with gcc 7.x:
>>
>> xc_dom_arm.c:229:31: error: 'domctl.u.address_size.size' may be used 
>> uninitialized in this function [-Werror=maybe-uninitialized]
>>      if ( domctl.u.address_size.size == 0 )
>>
>> Patch originally taken from
>> https://www.mail-archive.com/xen-devel@xxxxxxxxxxxxx/msg109313.html.
>>
>> Signed-off-by: Bernd Kuhls <bernd.kuhls@xxxxxxxxxxx>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
>
>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Please can this patch be backported / cherry-picked into Xen 4.9.

commit 88bfbf90e35f1213f9967a97dee0b2039f9998a4

thanks

Christopher

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.