Re: [Xen-devel] [PATCH] libxl: add back libxl_device_v{k,f}b_add

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Sep 14, 2017 at 05:27:07PM +0300, Oleksandr Grytsov wrote:
> 
> I've removed these functions as they weren't used. For proper removing
> they should be removed from header as well.
> If they are required by some extern application could they use generic
> async function to add vkb and vfb as other devices use:
> 

They were public functions. That means they can be used by any libxl
users, not just xl.

>  static void libxl__device_vkb_add(libxl__egc *egc, uint32_t domid,
>                                      libxl_device_vkb *vkb,
>                                      libxl__ao_device *aodev)
> {
>     libxl__device_add_async(egc, domid, &libxl__vkb_devtype, vkb, aodev);
> }
> 
> LIBXL_DEFINE_DEVICE_ADD(vkb)

Then that change them from sync to async. I didn't have the time to work
out if that would be okay so I played safe here.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel