Re: [Xen-devel] [PATCH v5 04/11] x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved for PVH Dom0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.09.17 at 17:55, <roger.pau@xxxxxxxxxx> wrote:
> On Tue, Sep 05, 2017 at 08:57:54AM -0600, Jan Beulich wrote:
>> >>> On 14.08.17 at 16:28, <roger.pau@xxxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/physdev.c
>> > +++ b/xen/arch/x86/physdev.c
>> > @@ -559,6 +559,15 @@ ret_t do_physdev_op(int cmd, 
>> > XEN_GUEST_HANDLE_PARAM(void) arg)
>> >  
>> >          ret = pci_mmcfg_reserved(info.address, info.segment,
>> >                                   info.start_bus, info.end_bus, 
>> > info.flags);
>> > +        if ( ret || !is_hvm_domain(currd) )
>> > +            break;
>> 
>> Don't you also want to check has_vpci() here?
> 
> I don't think the also is needed here, just checking for has_vpci
> should be fine (PV guests will not have the vpci flag set in any
> case).

Ah, right, emulation_flags is not in the HVM/PV union, but available
for all guests.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel