Re: [Xen-devel] [PATCH 03/17] x86emul: build SIMD tests with -Os

[George Dunlap <dunlapg@xxxxxxxxx>]

On Wed, Jun 21, 2017 at 1:00 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> Namely in the context of putting together subsequent patches I've
> noticed that together with the touch() macro using -Os further
> increases the chances of the compiler using memory operands for the
> instructions we actually care to test.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

I'm not sure how I'm supposed to evaluate the claim, but it certainly
looks like the patch does what it does on the tin, so:

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

>
> --- a/tools/tests/x86_emulator/Makefile
> +++ b/tools/tests/x86_emulator/Makefile
> @@ -45,17 +45,17 @@ define simd-defs
>  $(1)-cflags := \
>         $(foreach vec,$($(1)-vecs), \
>           $(foreach int,$($(1)-ints), \
> -           "-D_$(vec)i$(int) -m$(1) $(call non-sse,$(1)) -O2 
> -DVEC_SIZE=$(vec) -DINT_SIZE=$(int)" \
> -           "-D_$(vec)u$(int) -m$(1) $(call non-sse,$(1)) -O2 
> -DVEC_SIZE=$(vec) -DUINT_SIZE=$(int)") \
> +           "-D_$(vec)i$(int) -m$(1) $(call non-sse,$(1)) -Os 
> -DVEC_SIZE=$(vec) -DINT_SIZE=$(int)" \
> +           "-D_$(vec)u$(int) -m$(1) $(call non-sse,$(1)) -Os 
> -DVEC_SIZE=$(vec) -DUINT_SIZE=$(int)") \
>           $(foreach flt,$($(1)-flts), \
> -           "-D_$(vec)f$(flt) -m$(1) $(call non-sse,$(1)) -O2 
> -DVEC_SIZE=$(vec) -DFLOAT_SIZE=$(flt)")) \
> +           "-D_$(vec)f$(flt) -m$(1) $(call non-sse,$(1)) -Os 
> -DVEC_SIZE=$(vec) -DFLOAT_SIZE=$(flt)")) \
>         $(foreach flt,$($(1)-flts), \
> -         "-D_f$(flt) -m$(1) $(call non-sse,$(1)) -mfpmath=sse -O2 
> -DFLOAT_SIZE=$(flt)")
> +         "-D_f$(flt) -m$(1) $(call non-sse,$(1)) -mfpmath=sse -Os 
> -DFLOAT_SIZE=$(flt)")
>  $(1)-avx-cflags := \
>         $(foreach vec,$($(1)-vecs), \
>           $(foreach int,$($(1)-ints), \
> -           "-D_$(vec)i$(int) -m$(1) $(sse2avx-$(1)) -O2 -DVEC_SIZE=$(vec) 
> -DINT_SIZE=$(int)" \
> -           "-D_$(vec)u$(int) -m$(1) $(sse2avx-$(1)) -O2 -DVEC_SIZE=$(vec) 
> -DUINT_SIZE=$(int)"))
> +           "-D_$(vec)i$(int) -m$(1) $(sse2avx-$(1)) -Os -DVEC_SIZE=$(vec) 
> -DINT_SIZE=$(int)" \
> +           "-D_$(vec)u$(int) -m$(1) $(sse2avx-$(1)) -Os -DVEC_SIZE=$(vec) 
> -DUINT_SIZE=$(int)"))
>  endef
>
>  $(foreach flavor,$(SIMD),$(eval $(call simd-defs,$(flavor))))
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> https://lists.xen.org/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel