Re: [Xen-devel] [PATCH v2 0/7] xen/arm: Clean-up traps.c

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 12 Sep 2017, Julien Grall wrote:
> Hi all,
> 
> xen/arch/arm/traps.c is beginning to get very big. This series is moving out
> the co-processor and sysreg emulation in separate files. This will avoid to
> grow traps.c when adding more registers emulation (coming soon).
> 
> A branch with this series has been pushed:
> 
> https://xenbits.xen.org/git-http/people/julieng/xen-unstable.git
> branch cleanup-traps-v2

I committed the first two patches. Only a couple of very minor comments
on the rest.


> Cheers,
> 
> Cc: volodymyr_babchuk@xxxxxxxx
> 
> Julien Grall (7):
>   xen/arm: traps: Re-order the includes alphabetically
>   xen/arm: Move arch/arm/vtimer.h to include/asm-arm/vtimer.h
>   xen/arm: traps: Export a bunch of helpers to handle emulation
>   xen/arm: Move sysreg emulation outside of traps.c
>   xen/arm: Move co-processor emulation outside of traps.c
>   xen/arm: Move sysregs.h in arm64 sub-directory
>   xen/arm: Limit the scope of cpregs.h
> 
>  xen/arch/arm/Makefile                      |   1 +
>  xen/arch/arm/arm64/Makefile                |   1 +
>  xen/arch/arm/arm64/vsysreg.c               | 229 ++++++++++
>  xen/arch/arm/domain.c                      |   2 +-
>  xen/arch/arm/smp.c                         |   1 -
>  xen/arch/arm/traps.c                       | 702 
> ++---------------------------
>  xen/arch/arm/vcpreg.c                      | 452 +++++++++++++++++++
>  xen/arch/arm/vgic-v3.c                     |   1 +
>  xen/arch/arm/vtimer.c                      |   2 +
>  xen/include/asm-arm/arm32/processor.h      |   2 +
>  xen/include/asm-arm/arm32/traps.h          |  13 +
>  xen/include/asm-arm/arm64/processor.h      |   2 +
>  xen/include/asm-arm/{ => arm64}/sysregs.h  |  10 +-
>  xen/include/asm-arm/arm64/traps.h          |  18 +
>  xen/include/asm-arm/percpu.h               |   1 -
>  xen/include/asm-arm/processor.h            |   2 -
>  xen/include/asm-arm/traps.h                |  44 ++
>  xen/{arch/arm => include/asm-arm}/vtimer.h |   0
>  18 files changed, 811 insertions(+), 672 deletions(-)
>  create mode 100644 xen/arch/arm/arm64/vsysreg.c
>  create mode 100644 xen/arch/arm/vcpreg.c
>  create mode 100644 xen/include/asm-arm/arm32/traps.h
>  rename xen/include/asm-arm/{ => arm64}/sysregs.h (98%)
>  create mode 100644 xen/include/asm-arm/arm64/traps.h
>  create mode 100644 xen/include/asm-arm/traps.h
>  rename xen/{arch/arm => include/asm-arm}/vtimer.h (100%)
> 
> -- 
> 2.11.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel