Re: [Xen-devel] [PATCH v3 02/17] livepatch: Tighten alignment checks.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.09.17 at 02:37, <konrad@xxxxxxxxxx> wrote:
> The ELF specification mentions nothing about the sh_size being
> modulo the sh_addralign. Only that sh_addr MUST be aligned on
> sh_addralign if sh_addralign is not zero or one.
> 
> We on loading did not take this in-to account so this patch adds
> a check on the ELF file as it is being parsed.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit generally I'd recommend the check to be done in the
opposite order.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel