Re: [Xen-devel] [PATCH v5 09/12] libxl: change disk to use generic getting list functions

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 11, 2017 at 08:14:59PM +0300, Oleksandr Grytsov wrote:
> From: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
> 
> Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

With one nit:
> ---
>  tools/libxl/libxl.h                   |  9 +++-
>  tools/libxl/libxl_checkpoint_device.c |  7 ++-
>  tools/libxl/libxl_create.c            |  4 +-
>  tools/libxl/libxl_disk.c              | 83 
> +++++++++--------------------------
>  tools/libxl/libxl_internal.h          |  7 ---
>  tools/ocaml/libs/xl/xenlight_stubs.c  |  3 +-
>  tools/xl/xl_block.c                   |  3 +-
>  7 files changed, 34 insertions(+), 82 deletions(-)
> 
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index e386357..d5a3ab7 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -1749,9 +1749,14 @@ int libxl_device_disk_destroy(libxl_ctx *ctx, uint32_t 
> domid,
>                                const libxl_asyncop_how *ao_how)
>                                LIBXL_EXTERNAL_CALLERS_ONLY;
>  
> -libxl_device_disk *libxl_device_disk_list(libxl_ctx *ctx, uint32_t domid, 
> int *num);
> +libxl_device_disk *libxl_device_disk_list(libxl_ctx *ctx,
> +                                          uint32_t domid, int *num)
> +                                          LIBXL_EXTERNAL_CALLERS_ONLY;
> +void libxl_device_disk_list_free(libxl_device_disk* list, int num)
> +                                 LIBXL_EXTERNAL_CALLERS_ONLY;

'*' is in the wrong place.

> +void libxl_device_disk_list_free(libxl_device_disk* list, int num)

Ditto.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel