Re: [Xen-devel] [PATCH] pci: constify domain parameter of pci_get_pdev_by_domain

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Sep 11, 2017 at 03:09:54AM -0600, Jan Beulich wrote:
> >>> On 08.09.17 at 20:08, <andrew.cooper3@xxxxxxxxxx> wrote:
> > As as bdf is also quite a common unit, how about:
> > 
> >>
> >> typedef union {
> >>     uint32_t sbdf;
> >>     struct {
> > 
> > union {
> >     uint16_t bdf;
> >     struct {
> 
> Yes.
> 
> >>         union {
> >>             struct {
> >>                 uint8_t  func : 3, /* Function */
> >>                          slot : 5; /* Device   */
> > 
> > dev or device, surely?
> 
> Yeah, comment and field name would better match (or the comments
> could perhaps go away altogether). While "slot" is a common term
> here, with this being inside something called "sbdf" I agree "device"
> or "dev" (in the former case it should also be "function", but I prefer
> the shorter variants) should be used here.

I've used "slot" because I thought it was more common in the pci code,
we already have kind of weird naming, for example we usually use
PCI_SLOT(devfn). I don't have an opinion here, so I will switch to
'dev'.

I'm not sure what's the best way to introduce this, would you like it
to be part of my PCI emulation series?

I certainly don't plan to switch existing callers unless I need to
modify them anyway.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel