Re: [Xen-devel] [PATCH] monitor: switch to plain bool

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 08, 2017 at 08:14:59AM -0600, Jan Beulich wrote:
> >>> On 08.09.17 at 15:44, <wei.liu2@xxxxxxxxxx> wrote:
> > @@ -41,7 +41,7 @@ bool_t hvm_monitor_cr(unsigned int index, unsigned long 
> > value, unsigned long old
> >            value != old) &&
> >           (!((value ^ old) & ad->monitor.write_ctrlreg_mask[index])) )
> >      {
> > -        bool_t sync = !!(ad->monitor.write_ctrlreg_sync & ctrlreg_bitmask);
> > +        bool sync = !!(ad->monitor.write_ctrlreg_sync & ctrlreg_bitmask);
> 
> If you do such conversion, please also get rid of any unnecessary
> !! like is being used here (there are very few cases where these
> can't be dropped).
> 

Sure. I will keep an eye out in the future.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel