[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 1/2] paravirt/locks: use new static key for controlling call of virt_spin_lock()
- To: Waiman Long <longman@xxxxxxxxxx>
- From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
- Date: Wed, 6 Sep 2017 18:04:15 +0200
- Cc: Juergen Gross <jgross@xxxxxxxx>, jeremy@xxxxxxxx, rusty@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, chrisw@xxxxxxxxxxxx, mingo@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, hpa@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, akataria@xxxxxxxxxx, boris.ostrovsky@xxxxxxxxxx
- Delivery-date: Wed, 06 Sep 2017 16:04:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Wed, Sep 06, 2017 at 11:49:49AM -0400, Waiman Long wrote:
> > #define virt_spin_lock virt_spin_lock
> > static inline bool virt_spin_lock(struct qspinlock *lock)
> > {
> > + if (!static_branch_likely(&virt_spin_lock_key))
> > + return false;
> > if (!static_cpu_has(X86_FEATURE_HYPERVISOR))
> > return false;
> >
Now native has two NOPs instead of one. Can't we merge these two static
branches?
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|