[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 1/2] tools: use '__i386__' and '__x86_64__' to replace PSR macros

On Mon, Sep 04, 2017 at 05:07:26PM +0100, Roger Pau Monné wrote:
> On Mon, Sep 04, 2017 at 07:01:43PM +0800, Yi Sun wrote:
> > The libxl interfaces and related functions are not necessary to be included 
> > by
> > 'LIBXL_HAVE_PSR_CMT' and 'LIBXL_HAVE_PSR_CAT'. So replace them to common x86
> > macros. Furthermore, only compile 'xl_psr.c' under x86.
> > 
> > Suggested-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > Suggested-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks for your review.

Both patches:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> With some comments, that I would let the maintainers decide what's
> best to do.

I think you comments make sense but probably not worthy of sending
another round because of that. I believe Yi's time, and ours, is better
spent working on things that are more important. :-)

I will commit this series shortly.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.