Re: [Xen-devel] [PATCH v2 3/8] xen: delay allocation of grant table sub structures

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Juergen Gross [mailto:jgross@xxxxxxxx]
> Sent: 06 September 2017 10:42
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxx
> Cc: sstabellini@xxxxxxxxxx; Wei Liu <wei.liu2@xxxxxxxxxx>; George Dunlap
> <George.Dunlap@xxxxxxxxxx>; Andrew Cooper
> <Andrew.Cooper3@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Tim
> (Xen.org) <tim@xxxxxxx>; jbeulich@xxxxxxxx
> Subject: Re: [Xen-devel] [PATCH v2 3/8] xen: delay allocation of grant table
> sub structures
> 
> On 06/09/17 10:44, Paul Durrant wrote:
> >> -----Original Message-----
> >> From: Xen-devel [mailto:xen-devel-bounces@xxxxxxxxxxxxx] On Behalf Of
> >> Juergen Gross
> >> Sent: 06 September 2017 09:26
> >> To: xen-devel@xxxxxxxxxxxxx
> >> Cc: Juergen Gross <jgross@xxxxxxxx>; sstabellini@xxxxxxxxxx; Wei Liu
> >> <wei.liu2@xxxxxxxxxx>; George Dunlap <George.Dunlap@xxxxxxxxxx>;
> >> Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Ian Jackson
> >> <Ian.Jackson@xxxxxxxxxx>; Tim (Xen.org) <tim@xxxxxxx>;
> >> jbeulich@xxxxxxxx
> >> Subject: [Xen-devel] [PATCH v2 3/8] xen: delay allocation of grant table
> sub
> >> structures
> >>
> >> Delay the allocation of the grant table sub structures in order to
> >> allow modifying parameters needed for sizing of these structures at a
> >> per domain basis. Either do it from gnttab_setup_table() or just
> >> before the domain is started the first time.
> >
> > Why does it need to be in two places? Could it not just be done on the first
> call to gnttab_grow_table()?
> 
> Could be difficult for e.g. a xenstore domain: it might make use of
> the maptrack frames before that, so it would explode then.
> 
> It should be possible, however, to move the call to grant_table_init()
> from gnttab_setup_table() to gnttab_grow_table().
> 

Ok. Thanks,

  Paul

> 
> Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel