[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/4] DEPS handling: Remove absolute paths from references to cwd

>>> On 05.09.17 at 17:32, <ian.jackson@xxxxxxxxxxxxx> wrote:
> Jan Beulich writes ("Re: [PATCH 4/4] DEPS handling: Remove absolute paths 
> from references to cwd"):
>> On 04.09.17 at 18:46, <ian.jackson@xxxxxxxxxxxxx> wrote:
>> > +%.d2: %.d
>> Wouldn't it be better to use .%.d2 and .%.d here?
> Perhaps.  That makes the assumption that nothing anywhere adds
> anything to DEPS which does not match `.*.d'
> My formulation makes a smaller assumption about DEPS (nothing adds
> anything not ending with .d) but a larger assumption about .d (there
> are no Makefile pattern targets which use .d for other purposes).
> I think the 2nd assumption is reasonable and the expanded 1st
> assumption is questionable.

Well, these dependency files start with a dot for a reason. Plus
my consideration on *.d (without leading dot) was that this may
have a conventional use for D language source files (but that's
a guess, nothing I know). Anyway, as expressed I'm not meaning
to insist on the change, just put it out for consideration.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.