[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

To: Wei Liu <wei.liu2@xxxxxxxxxx>
From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date: Tue, 5 Sep 2017 13:58:53 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Oleksandr Grytsov <al1img@xxxxxxxxx>, Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
Delivery-date: Tue, 05 Sep 2017 12:59:06 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"):
> > +    rc = snprintf(connector_path, 128, "%s/%d", path, 
> > info->num_connectors);

Why not use GCSPRINTF ?  These statically sized buffers etc. are an
invitation to bugs.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device
  - From: Wei Liu

References:
- Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device
  - From: Wei Liu

Prev by Date: Re: [Xen-devel] [PATCH v4 09/13] libxl: change disk to use generic getting list functions
Next by Date: Re: [Xen-devel] [PATCH v4 10/13] libxl: change nic to use generec add function
Previous by thread: Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device
Next by thread: Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device
Index(es):
- Date
- Thread

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.