Re: [Xen-devel] [PATCH 22/27 v8] xen/arm: vpl011: Add support for vuart console in xenconsole

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx> 09/04/17 6:28 PM >>>
>On 28 August 2017 at 14:41, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 28.08.17 at 10:56, <bhupinder.thakur@xxxxxxxxxx> wrote:
>>> --- a/config/arm32.mk
>>> +++ b/config/arm32.mk
>>> @@ -1,5 +1,6 @@
>>>  CONFIG_ARM := y
>>>  CONFIG_ARM_32 := y
>>> +CONFIG_VUART_CONSOLE := y
>>>  CONFIG_ARM_$(XEN_OS) := y
>>>
>>>  CONFIG_XEN_INSTALL_SUFFIX :=
>>> diff --git a/config/arm64.mk b/config/arm64.mk
>>> index aa45772..861d0a4 100644
>>> --- a/config/arm64.mk
>>> +++ b/config/arm64.mk
>>> @@ -1,5 +1,6 @@
>>>  CONFIG_ARM := y
>>>  CONFIG_ARM_64 := y
>>> +CONFIG_VUART_CONSOLE := y
>>>  CONFIG_ARM_$(XEN_OS) := y
>>
>> I think this wants to be solved better than by starting to again
>> introduce CONFIG_* values here.
>
>I think I can remove this flag from here since it is used currently
>for xenconsole only to enable VUART console support for ARM. I can
>directly define the flag in the tools/console Makefile based on
>CONFIG_ARM option.

If it's unconditionally on for ARM, what's the extra CONFIG_* good for?
And if it was meant to be conditionally selectable, then a configure
based approach would be needed. But anyway, once this affects
tools/ only, the tools maintainers will know best.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel