Re: [Xen-devel] [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support

["Tan, Jianfeng" <jianfeng.tan@xxxxxxxxx>]

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Monday, September 4, 2017 10:49 PM
> To: Tan, Jianfeng
> Cc: dev@xxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx; thomas@xxxxxxxxxxxx;
> Mcnamara, John; joao.m.martins@xxxxxxxxxx;
> jerin.jacob@xxxxxxxxxxxxxxxxxx; shahafs@xxxxxxxxxxxx
> Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support
> 
> On Mon, Sep 04, 2017 at 03:43:02PM +0100, Bruce Richardson wrote:
> > On Wed, Aug 30, 2017 at 06:10:33PM +0000, Jianfeng Tan wrote:
> > > We remove xen-specific code in EAL, including the option --xen-dom0,
> > > memory initialization code, compiling dependency, etc.
> > >
> > > Besides, related documents are removed or updated.
> > >
> > > Signed-off-by: Jianfeng Tan <jianfeng.tan@xxxxxxxxx>
> > > ---
> > >  MAINTAINERS                                        |   7 -
> > >  config/common_base                                 |   5 -
> > >  doc/guides/index.rst                               |   1 -
> > >  doc/guides/linux_gsg/build_sample_apps.rst         |   5 +-
> > >  doc/guides/linux_gsg/sys_reqs.rst                  |  53 --
> > >  doc/guides/prog_guide/source_org.rst               |   1 -
> > >  doc/guides/rel_notes/deprecation.rst               |   3 -
> > >  doc/guides/rel_notes/release_17_11.rst             |  12 +
> > >  doc/guides/testpmd_app_ug/run_app.rst              |   4 -
> > >  doc/guides/xen/img/dpdk_xen_pkt_switch.png         | Bin 163842 -> 0
> bytes
> > >  doc/guides/xen/img/grant_refs.png                  | Bin 6405 -> 0 bytes
> > >  doc/guides/xen/img/grant_table.png                 | Bin 96762 -> 0 bytes
> > >  doc/guides/xen/index.rst                           |  38 -
> > >  doc/guides/xen/pkt_switch.rst                      | 470 -------------
> > >  .../bsdapp/eal/include/exec-env/rte_dom0_common.h  | 107 ---
> > >  lib/librte_eal/common/eal_common_options.c         |   3 -
> > >  lib/librte_eal/common/eal_internal_cfg.h           |   1 -
> > >  lib/librte_eal/common/eal_options.h                |   2 -
> > >  lib/librte_eal/common/include/rte_memory.h         |  66 --
> > >  lib/librte_eal/linuxapp/Makefile                   |   2 -
> > >  lib/librte_eal/linuxapp/eal/Makefile               |   5 +-
> > >  lib/librte_eal/linuxapp/eal/eal.c                  |  24 -
> > >  lib/librte_eal/linuxapp/eal/eal_memory.c           |  56 --
> > >  lib/librte_eal/linuxapp/eal/eal_xen_memory.c       | 381 ----------
> > >  .../eal/include/exec-env/rte_dom0_common.h         | 108 ---
> > >  lib/librte_eal/linuxapp/igb_uio/igb_uio.c          |  54 --
> > >  lib/librte_eal/linuxapp/xen_dom0/Makefile          |  53 --
> > >  lib/librte_eal/linuxapp/xen_dom0/compat.h          |  15 -
> > >  lib/librte_eal/linuxapp/xen_dom0/dom0_mm_dev.h     | 107 ---
> > >  lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c    | 780 --------------
> -------
> > >  pkg/dpdk.spec                                      |   3 -
> >
> > The xen functions that were removed are still listed in the linux/bsd
> > version.map files. Not an ABI versioning expert, but I believe they
> > should be removed as they are no longer present.
> >
> Reading the contributors guide section on ABI, specifically
> http://dpdk.org/doc/guides/contributing/versioning.html#deprecating-an-
> entire-abi-version
> it seems like we should collapse down the versions to a single one
> following the function removal, and also increment the whole library so
> version.

So for lib/librte_eal/linuxapp/eal/rte_eal_version.map, we should change it in 
below way?

DPDK_2.1 {
        {APIs in DPDK_2.0 except xen APIs}
        ...
};

DPDK_16.04 {
        {APIs in DPDK_2.1 except xen APIs}
        ...
} DPDK_2.1;

DPDK_16.07 {
        ...
} DPDK_16.04;
...

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel