Re: [Xen-devel] [PATCH] x86/mm: use put_page_type_preemptible in put_page_from_l{3, 4}e

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 04/09/17 12:45, Wei Liu wrote:
> On Mon, Sep 04, 2017 at 12:42:06PM +0100, Wei Liu wrote:
>> No functional change.
>>
>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>> ---
>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>> ---
>>  xen/arch/x86/mm.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
>> index e5b0cceae4..314da84720 100644
>> --- a/xen/arch/x86/mm.c
>> +++ b/xen/arch/x86/mm.c
> In fact the forward declaration for __put_page_type here can also be
> deleted.

With this done, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>> @@ -1376,7 +1376,7 @@ static int put_page_from_l3e(l3_pgentry_t l3e, 
>> unsigned long pfn,
>>      if ( unlikely(partial > 0) )
>>      {
>>          ASSERT(!defer);
>> -        return __put_page_type(pg, 1);
>> +        return put_page_type_preemptible(pg);
>>      }
>>  
>>      if ( defer )
>> @@ -1399,7 +1399,7 @@ static int put_page_from_l4e(l4_pgentry_t l4e, 
>> unsigned long pfn,
>>          if ( unlikely(partial > 0) )
>>          {
>>              ASSERT(!defer);
>> -            return __put_page_type(pg, 1);
>> +            return put_page_type_preemptible(pg);
>>          }
>>  
>>          if ( defer )
>> -- 
>> 2.11.0
>>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel