Re: [Xen-devel] [PATCH v2 08/15] tools: create general interfaces to support psr allocation features

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 04, 2017 at 10:09:48AM +0800, Yi Sun wrote:
> On 17-08-31 09:37:45, Roger Pau Monn� wrote:
> > On Thu, Aug 31, 2017 at 10:38:46AM +0800, Yi Sun wrote:
> > > On 17-08-30 09:42:56, Roger Pau Monn� wrote:
> > > > On Thu, Aug 24, 2017 at 09:14:42AM +0800, Yi Sun wrote:
> > > > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> > > > > index 6e80d36..ab847f8 100644
> > > > > --- a/tools/libxl/libxl_types.idl
> > > > > +++ b/tools/libxl/libxl_types.idl
> > > > > @@ -977,6 +977,7 @@ libxl_psr_cbm_type = Enumeration("psr_cbm_type", [
> > > > >      (2, "L3_CBM_CODE"),
> > > > >      (3, "L3_CBM_DATA"),
> > > > >      (4, "L2_CBM"),
> > > > > +    (5, "MBA_THRTL"),
> > > > 
> > > > Is this really a CBM type?
> > > > 
> > > This is not CBM type. The 'libxl_psr_cbm_type' name is not good enough. 
> > > But I
> > > have to introduce a new generic interface here if we want to make the 
> > > name be
> > > generic. I think it is not so valuable. So, I reuse the 
> > > 'libxl_psr_cbm_type'
> > > to cover MBA. How do you think?
> > 
> > Maybe you could introduce a new typedef, so that old code call still
> > work, ie:
> > 
> > typedef enum libxl_psr_cbm_type libxl_psr_type;
> > 
> Is there a way in '.idl' to make such 'typedef'? Thanks!
> 

No (or not yet?).

Please do it in libxl.h.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel