Re: [Xen-devel] [PATCH] x86/shadow: Clarify the safety of guest-linear mapping construction

[Tim Deegan <tim@xxxxxxx>]

At 16:29 +0100 on 01 Sep (1504283350), Andrew Cooper wrote:
> sh_install_xen_entries_in_l4() looks unsafe, as it creates a guest-linear
> mapping with gl4mfn.  However, it is correct because of the way monitor tables
> are constructed for translated domains.
> 
> Leave a comment and some clarifying assertions.
> 
> Also, there is no longer support for translate != external, so drop the clause
> as it is dead.
> 
> Finally, correct the comment for sh_install_xen_entries_in_l2h().  We need to
> add Xen mappings into l2h for 3-on-any PV guests.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Tim Deegan <tim@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel