Re: [Xen-devel] [PATCH v2 3/6] libxl:xl: add parsing code to parse "libxl_static_sshm" from xl config files

[Zhongze Liu <blackskygg@xxxxxxxxx>]

2017-09-02 0:03 GMT+08:00 Wei Liu <wei.liu2@xxxxxxxxxx>:
> On Sun, Aug 27, 2017 at 04:36:12PM +0800, Zhongze Liu wrote:
>> Add the parsing utils for the newly introduced libxl_static_sshm struct
>> to the libxl/libxlu_* family. And add realated parsing code in xl to
>> parse the struct from xl config files. This is for the proposal "Allow
>> setting up shared memory areas between VMs from xl config file" (see [1]).
>>
>> [1] https://lists.xen.org/archives/html/xen-devel/2017-08/msg03242.html
>>
>> Signed-off-by: Zhongze Liu <blackskygg@xxxxxxxxx>
>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>
> I am wondering if there is a chance to extract the key=value parsing
> into standalone function and use it everywhere though.

I think this is a good idea.

>
>>
>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
>> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> Cc: Tim Deegan <tim@xxxxxxx>
>> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
>> Cc: Julien Grall <julien.grall@xxxxxxx>
>> Cc: xen-devel@xxxxxxxxxxxxx
>
> Correctly trim your CC list next time please. A lot of hypervisor people
> don't need to get CCed on this patch.

Actually, this list is generated by get_maintainer.pl. Maybe next time I should
go carefully through the list and remove some of the names manually.

Cheers,

Zhongze Liu

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel