Re: [Xen-devel] [PATCH v1] x86/hvm: Expose MSR_SHADOW_GS_BASE

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.09.17 at 12:44, <aisaila@xxxxxxxxxxxxxxx> wrote:
> This patch is adding an new param in the hvm_hw_cpu structure
> so it can be exposed to user space.

But you don't say why.

> --- a/xen/include/public/arch-x86/hvm/save.h
> +++ b/xen/include/public/arch-x86/hvm/save.h
> @@ -134,6 +134,8 @@ struct hvm_hw_cpu {
>      /* msr for em64t */
>      uint64_t shadow_gs;
>  
> +    uint64_t shadow_gs_base;

You can't alter a public interface structure like this. The one here
is used for migration, so migrating guests from an older hypervisor
would break.

But what's more funny - you're adding a field next to what looks
like already has the value you're after.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel