Re: [Xen-devel] [PATCH] x86/pvh: remove stale PVHv1 comment from public headers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.08.17 at 16:58, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/include/public/arch-x86/xen.h
> +++ b/xen/include/public/arch-x86/xen.h
> @@ -162,14 +162,10 @@ typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp 
> */
>   * The following is all CPU context. Note that the fpu_ctxt block is filled
>   * in by FXSAVE if the CPU has feature FXSR; otherwise FSAVE is used.
>   *
> - * Also note that when calling DOMCTL_setvcpucontext and VCPUOP_initialise
> - * for HVM and PVH guests, not all information in this structure is updated:
> - *
> - * - For HVM guests, the structures read include: fpu_ctxt (if
> - * VGCT_I387_VALID is set), flags, user_regs, debugreg[*]
> - *
> - * - PVH guests are the same as HVM guests, but additionally use ctrlreg[3] 
> to
> - * set cr3. All other fields not used should be set to 0.
> + * Also note that when calling DOMCTL_setvcpucontext and VCPUOP_initialise 
> for
> + * HVM guests, not all information in this structure is updated, the 
> structure
> + * read include: fpu_ctxt (if VGCT_I387_VALID is set), flags, user_regs and
> + * debugreg[*].

Instead of "the structure read" (where you've lost the plural),
how about "the fields read" or "the pieces read"? With either of
these (easily doable while committing)
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel