Re: [Xen-devel] [PATCH v2 10/15] tools: implement the new libxl get hw info interface

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-08-31 10:32:09, Roger Pau Monn� wrote:
> On Thu, Aug 31, 2017 at 05:19:56PM +0800, Yi Sun wrote:
> > On 17-08-31 09:40:37, Roger Pau Monn� wrote:
> > > On Thu, Aug 31, 2017 at 11:16:34AM +0800, Yi Sun wrote:
> > > > On 17-08-30 10:15:22, Roger Pau Monn� wrote:
> > > > > On Thu, Aug 24, 2017 at 09:14:44AM +0800, Yi Sun wrote:
> > > Has libxl_psr_cat_get_info been present in any Xen release? (I don't
> > > think so) If it hasn't then you can change the interface without
> > > issues.
> > > 
> > libxl_psr_cat_get_info is just introduced and not released yet. But 
> > libxl_psr_cat_get_l3_info has been released for long time. It declares
> > 'int *nr' and it calls 'libxl_psr_cat_get_info' to do the work. So, there
> > must be a casting anyway.
> > 
> > What do you suggest? Shall I submit a patch to fix 'libxl_psr_cat_get_info'?
> > Or, a patch to fix both 'libxl_psr_cat_get_info' and 
> > 'libxl_psr_cat_get_l3_info'?
> 
> Just fixing libxl_psr_cat_get_info would be fine IMHO, let's try to
> limit the int usage as much as possible.
> 
Ok, then, I think another separate fix patch is needed.

> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel