Re: [Xen-devel] [PATCH v4] hvmloader, libxl: use the correct ACPI settings depending on device model

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Aug 30, 2017 at 02:31:54AM -0600, Jan Beulich wrote:
> >>> On 29.08.17 at 18:29, <igor.druzhinin@xxxxxxxxxx> wrote:
> > --- a/tools/firmware/hvmloader/util.h
> > +++ b/tools/firmware/hvmloader/util.h
> > @@ -276,6 +276,9 @@ extern struct e820map memory_map;
> >  bool check_overlap(uint64_t start, uint64_t size,
> >                     uint64_t reserved_start, uint64_t reserved_size);
> >  
> > +extern unsigned char dsdt_anycpu_qemu_xen[], dsdt_anycpu[], dsdt_15cpu[];
> 
> Preferably const, unless this requires to much other code to be
> changed.
> 
> > @@ -472,6 +472,8 @@ int libxl__domain_build(libxl__gc *gc,
> >                                     info->u.hvm.mmio_hole_memkb << 10);
> >              }
> >          }
> > +        localents[i++] = "platform/device-model";
> > +        localents[i++] = (char *) 
> > libxl_device_model_version_to_string(info->device_model_version);
> 
> If this was hypervisor code, I'd complain about the blank following
> the closing parenthesis; not sure what the libxl conventions are
> in this regard.
> 

We don't have strict requirement in CODING_STYLE. I normally would
prefer not having the space there.

I can fix that up while committing but Igor please change it if you need
to resend this patch.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel