Re: [Xen-devel] [PATCH v8] x86/hvm: Allow guest_request vm_events coming from userspace

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Mon, Aug 28, 2017 at 7:29 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 28.08.17 at 14:51, <aisaila@xxxxxxxxxxxxxxx> wrote:
>> --- a/xen/include/asm-arm/monitor.h
>> +++ b/xen/include/asm-arm/monitor.h
>> @@ -26,6 +26,12 @@
>>  #include <public/domctl.h>
>>
>>  static inline
>> +void arch_allow_userspace(struct domain *d, uint8_t allow_userspace)
>> +{
>> +    return;
>> +}
>
> I'm sorry for noticing this only now, but the name of the hook really
> ought to have vm_event or monitor in it - it's way too generic the
> way it is now.
>

+1 I've just stated that too on apparently the previous version of the patch =)

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel