[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 01/21] x86/mm: carve out create_grant_pv_mapping

To: Wei Liu <wei.liu2@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
From: George Dunlap <george.dunlap@xxxxxxxxxx>
Date: Mon, 28 Aug 2017 16:16:39 +0100
Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
Delivery-date: Mon, 28 Aug 2017 15:16:54 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 07/20/2017 05:04 PM, Wei Liu wrote:
> And at once make create_grant_host_mapping an inline function.  This

"At once" means "immediately" or "without any delay between this event
and the preceding event", which doesn't make sense here.  I think you
want, "At the same time."

Other than that, looks good:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

Prev by Date: Re: [Xen-devel] [PATCH v2 REPOST 11/12] x86/hvm/ioreq: defer mapping gfns until they are actually requsted
Next by Date: Re: [Xen-devel] [PATCH v3 02/21] x86/mm: carve out replace_grant_pv_mapping
Previous by thread: [Xen-devel] [ovmf baseline-only test] 72033: all pass
Next by thread: Re: [Xen-devel] [PATCH v3 02/21] x86/mm: carve out replace_grant_pv_mapping
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.