Re: [Xen-devel] [PATCH v3] passthrough: give XEN_DOMCTL_test_assign_device more sane semantics

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.08.17 at 17:54, <JBeulich@xxxxxxxx> wrote:
>>>> On 25.08.17 at 17:25, <wei.liu2@xxxxxxxxxx> wrote:
>> On Wed, Aug 16, 2017 at 06:20:01AM -0600, Jan Beulich wrote:
>>> So far callers of the libxc interface passed in a domain ID which was
>>> then ignored in the hypervisor. Instead, make the hypervisor honor it
>>> (accepting DOMID_INVALID to obtain original behavior), allowing to
>>> query whether a device can be assigned to a particular domain.
>>> 
>>> Drop XSM's test_assign_{,dt}device hooks as no longer being
>>> individually useful.
>> 
>> Can you also say in the commit message that you consolidate some code as
>> well?
> 
> Am I consolidating code beyond what is reasonable to achieve
> the intended effect? I don't view the merging of the two case
> blocks 

Oops, didn't finish here: "... as anything going beyond the main
purpose of the patch. In fact if someone submitted a patch
without doing that folding, I'd ask for it to be done."

>> Assuming the disagreement on the semantics of the call is settled:
>> 
>> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

And didn't say "thanks" here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel