Re: [Xen-devel] [PATCH 2/5] xen: move XENMAPSPACE_grant_table code into grant_table.c

[Juergen Gross <jgross@xxxxxxxx>]

On 24/08/17 18:12, Julien Grall wrote:
> Hello,
> 
> I was expecting to be CCed on this patch.

Oops, sorry for that.

> 
> On 21/08/17 19:05, Juergen Gross wrote:
>> The x86 and arm versions of XENMAPSPACE_grant_table handling are nearly
>> identical. Move the code into a function in grant_table.c and add an
>> architecture dependant hook to handle the differences.
>>
>> This at once fixes a bug in the arm code which didn't unlock the grant
>> table in error case.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> ---
>>  xen/arch/arm/mm.c                 | 34 ++++----------------------------
>>  xen/arch/x86/mm.c                 | 41
>> ++++++++++-----------------------------
>>  xen/common/grant_table.c          | 38
>> ++++++++++++++++++++++++++++++++++++
>>  xen/include/asm-arm/grant_table.h |  6 ++++++
>>  xen/include/asm-x86/grant_table.h |  5 +++++
>>  xen/include/xen/grant_table.h     |  3 +++
>>  6 files changed, 66 insertions(+), 61 deletions(-)
>>
>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>> index a810a056d7..6dad167a8e 100644
>> --- a/xen/arch/arm/mm.c
>> +++ b/xen/arch/arm/mm.c
>> @@ -24,6 +24,7 @@
>>  #include <xen/mm.h>
>>  #include <xen/preempt.h>
>>  #include <xen/errno.h>
>> +#include <xen/sched.h>
> 
> Why sched.h has been moved earlier? Likely it means one of the header
> doesn't include all its dependency.

I'll have a look.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel