[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 27/27] xen/arm: mm: Use memory flags for modify_xen_mappings rather than custom one

On 08/23/2017 03:10 PM, Andre Przywara wrote:


On 14/08/17 15:24, Julien Grall wrote:
This will help to consolidate the page-table code and avoid different
path depending on the action to perform.

Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

It could be worth to mention in the commit message that the removed
ASSERT is now already cared for in create_xen_entries() (which is also
another hint to make that an ASSERT, actually).

If you look at the code modify_xen_mappings is using the operation MODIFY which already had a permission check without this series.

But this ASSERT here does not do what you think. It only check that the flags PTE_NX and PTE_RO could be set, not the mapping is non-executable and writeable.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.