Re: [Xen-devel] [PATCH V2 22/25] x86/vmsi: Hook delivering remapping format msi to guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.08.17 at 12:55, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Aug 09, 2017 at 04:34:23PM -0400, Lan Tianyu wrote:
>> From: Chao Gao <chao.gao@xxxxxxxxx>
>> 
>> In two situations, hypervisor delivers a msi to a hvm guest. One is
>> when qemu sends a request to hypervisor through XEN_DMOP_inject_msi.
>> The other is when a physical interrupt arrives and it has been bound
>> to a guest msi.
>> 
>> For the former, the msi is routed to common vIOMMU layer if it is in
>> remapping format. For the latter, if the pt irq is bound to a guest
>> remapping msi, a new remapping msi is constructed based on the binding
>> information and routed to common vIOMMU layer.
> 
> After looking at the code below, I'm wondering whether it would make
> sense to add a new flag that's HVM_IRQ_DPCI_GUEST_REMAPPED or similar,
> so that you would use:
> 
> HVM_IRQ_DPCI_GUEST_MSI | HVM_IRQ_DPCI_GUEST_REMAPPED
> 
> In order to designate a remapped MSI. It seems like it would avoid
> some of the changes below (where you are just adding
> HVM_IRQ_DPCI_GUEST_MSI_IR to code paths already used by
> HVM_IRQ_DPCI_GUEST_MSI). More of a suggestion rather than a request
> for you to change the code.

I think this is a pretty good suggestion.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel