Re: [Xen-devel] [PATCH] hvmloader: add fields for SMBIOS 2.4 compliance

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.08.17 at 13:59, <wei.liu2@xxxxxxxxxx> wrote:
> On Wed, Aug 23, 2017 at 12:52:49PM +0100, Roger Pau Monne wrote:
>> On Wed, Aug 23, 2017 at 11:51:49AM +0100, Wei Liu wrote:
>> > On Tue, Aug 22, 2017 at 01:50:23PM +0100, Roger Pau Monne wrote:
>> > [...]
>> > > diff --git a/tools/firmware/hvmloader/smbios_types.h 
> b/tools/firmware/hvmloader/smbios_types.h
>> > > index e924f819b3..2bf1645bfa 100644
>> > > --- a/tools/firmware/hvmloader/smbios_types.h
>> > > +++ b/tools/firmware/hvmloader/smbios_types.h
>> > > @@ -104,6 +104,11 @@ struct smbios_type_3 {
>> > >      uint8_t power_supply_state;
>> > >      uint8_t thermal_state;
>> > >      uint8_t security_status;
>> > > +    uint32_t oem_specific;
>> > > +    uint8_t height;
>> > > +    uint8_t number_of_power_cords;
>> > > +    uint8_t contained_element_count;
>> > > +    uint8_t contained_element_length;
>> > 
>> > Missing contained_elements ?
>> 
>> contained_element_count is 0, so I don't think it's strictly needed.
>> If you think it's required I can represent it as an empty array ([0]).
>> 
> 
> I think that would be better but it is up to Jan and Andrew to decide.

Yes, I agree (but [] please, i.e. without the zero).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel