[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping
On 2017年08月23日 17:24, Jan Beulich wrote: >>>> On 23.08.17 at 09:42, <tianyu.lan@xxxxxxxxx> wrote: >> On 2017年08月22日 23:32, Roger Pau Monné wrote: >>> On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: >>>> +static inline void irq_request_ioapic_fill(struct irq_remapping_request >>>> *req, >>>> + uint32_t ioapic_id, uint64_t rte) >>>> +{ >>>> + ASSERT(req); >>>> + req->type = VIOMMU_REQUEST_IRQ_APIC; >>>> + req->source_id = ioapic_id; >>>> + req->msg.rte = rte; >>>> +} >>>> + >>>> +static inline void irq_request_msi_fill(struct irq_remapping_request *req, >>>> + uint32_t source_id, uint64_t addr, uint32_t >>>> data) >>>> +{ >>>> + ASSERT(req); >>>> + req->type = VIOMMU_REQUEST_IRQ_MSI; >>>> + req->source_id = source_id; >>>> + req->msg.msi.addr = addr; >>>> + req->msg.msi.data = data; >>>> +} >>> >>> What's the usage of those two functions? AFAICT they don't have any >>> callers in this patch. >> >> These functions will be called in the following interrupt patch 22 >> "x86/vmsi: Hook delivering remapping format msi to guest" and patch 16 >> "x86/vioapic: Hook interrupt delivery of vIOAPIC" > > That's _far_ away. As implied by Roger's comment, please try to > avoid introducing dead code, especially when it's dead for an > extended period of time. Always remember that a series may not > be committed in one go. OK. Will change order. -- Best regards Tianyu Lan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |