Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

[Lan Tianyu <tianyu.lan@xxxxxxxxx>]

On 2017年08月18日 18:13, Wei Liu wrote:
>>> ASSERT(info->viommu[viommu_id]->ops);
>>> > > 
>>> > > For extra safety.
>> > 
>> > Or check ops in the previous if?
>> > 
> That depends on if ops can be null or not.

If ops isn't be set, it will be null. Because struct viommu is allocated
via xzalloc().

> 
>>> diff --git a/xen/include/asm-x86/viommu.h b/xen/include/asm-x86/viommu.h
>>> > >> new file mode 100644
>>> > >> index 0000000..51bda72
>>> > >> --- /dev/null
>>> > >> +++ b/xen/include/asm-x86/viommu.h
>>> > >> @@ -0,0 +1,73 @@
>>> > >> +/*
>>> > >> + * include/asm-x86/viommu.h
>>> > >> + *
>>> > >> + * Copyright (c) 2017 Intel Corporation.
>>> > >> + * Author: Lan Tianyu <tianyu.lan@xxxxxxxxx> 
>>> > >> + *
>>> > >> + * This program is free software; you can redistribute it and/or 
>>> > >> modify it
>>> > >> + * under the terms and conditions of the GNU General Public License,
>>> > >> + * version 2, as published by the Free Software Foundation.
>>> > >> + *
>>> > >> + * This program is distributed in the hope it will be useful, but 
>>> > >> WITHOUT
>>> > >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY 
>>> > >> or
>>> > >> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public 
>>> > >> License for
>>> > >> + * more details.
>>> > >> + *
>>> > >> + * You should have received a copy of the GNU General Public License 
>>> > >> along with
>>> > >> + * this program; If not, see <http://www.gnu.org/licenses/>.
>>> > >> + *
>>> > >> + */
>>> > >> +#ifndef __ARCH_X86_VIOMMU_H__
>>> > >> +#define __ARCH_X86_VIOMMU_H__
>>> > >> +
>> > > 
>> > > Is a corresponding ARM header needed? Given viommu is common code.
>> 
>> I added such ARM header file in previous version but Julien hope vIOMMU
>> > should be disabled for ARM because ARM doesn't support vIOMMU so far.
>> > 
> If that's what he wanted, sure.
> 
> Please build test ARM as well. You can do so using travis-ci.

OK. Will test.
-- 
Best regards
Tianyu Lan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel