[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] hvm: vmx/svm_cpu_up_prepare should be called only once



>>> On 17.08.17 at 16:19, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -652,7 +652,7 @@ int vmx_cpu_up(void)
>  
>      INIT_LIST_HEAD(&this_cpu(active_vmcs_list));
>  
> -    if ( (rc = vmx_cpu_up_prepare(cpu)) != 0 )
> +    if ( (cpu == 0) && (rc = vmx_cpu_up_prepare(cpu)) != 0 )

Let's please not introduce any further "CPU0 is always to BSP"
assumptions - we ought to get to the point where CPU0 can be
hot-unplugged and then hot-plugged again.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.