Re: [Xen-devel] [PATCH v8 11/13] arm/mem_access: Add long-descriptor based gpt

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 15/08/2017 23:25, Stefano Stabellini wrote:
> On Tue, 15 Aug 2017, Julien Grall wrote:
>> On 14/08/17 22:03, Sergej Proskurin wrote:
>>> Hi Julien,
>>>
>>> On 08/14/2017 07:37 PM, Julien Grall wrote:
>>>> Hi Sergej,
>>>>
>>>> On 09/08/17 09:20, Sergej Proskurin wrote:
>>>>> +    /*
>>>>> +     * According to to ARM DDI 0487B.a J1-5927, we return an error if
>>>>> the found
>>>> Please drop one of the 'to'. The rest looks good to me.
>>>>
>>> Great, thanks. I will remove the second "to" in v9. Would that be an
>>> Acked-by or shall I tag this patch with a Reviewed-by you?
>> Acked-by. FIY, you still missing an acked from "The REST" for patch #7, the
>> rest looks fully acked.
> I acked patch #7, but patch #8 breaks the build on ARM:
>
>
> In file included from 
> /local/repos/xen-upstream/xen/include/xen/guest_access.h:10:0,
>                  from device_tree.c:15:
> /local/repos/xen-upstream/xen/include/asm/guest_access.h:14:32: error: 
> 'struct domain' declared inside parameter list [-Werror]
>                                 uint32_t size, bool_t is_write);
>                                 ^
> /local/repos/xen-upstream/xen/include/asm/guest_access.h:14:32: error: its 
> scope is only this definition or declaration, which is probably not what you 
> want [-Werror]
> cc1: all warnings being treated as errors
> make[4]: *** [device_tree.o] Error 1
>
>
> Am I missing anything?

Possibly a result of Wei's recent patch
http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=de62402a9c2e403b049aa238b4fa4e2d618e8870
which is newer than the posting of this series.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel