[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 00/52] Support for modifying parameters at runtime

>>> On 14.08.17 at 09:07, <jgross@xxxxxxxx> wrote:
> Currently parameters of the hypervisor (e.g. console log level) can be
> set via boot command line. Instead of having to reboot the system in
> case another setting is desired, being able to modify many of those
> parameters at runtime would be the better option.
> This patch series addresses this by adding a new xl command
> "xl set-parameters" which takes a string similar to the boot command
> line as parameter and passes this string to the hypervisor which will
> then use the same parsing infrastructure as for the command line in
> order to apply the parameter settings.
> As error checks for invalid parameters or parameter values have been
> very sparse if present at all in the hypervisor, a major part of this
> patch series addresses this problem first: all custom parameter parsing
> functions are being changed to return success or an error. The main
> parsing function tests for generic parameter value errors (like e.g.
> overflow) or invalid parameters and issues a message in case an error
> has been detected. Most error messages in the custom parsing functions
> are removed then.
> While not strictly required for runtime parameter modification I
> believe an improved parameter validation is a win with or without the
> runtime parameter modification support.
> * Patches 1-38 are modifying the custom parameter parsing functions to
>   return success or error

Patches 4-37 (where relevant, i.e. where I've been Cc-ed)
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
including ones where I've asked for merely cosmetic changes.
Ones where I've pointed out more are excluded. I also think
that while doing things this fine grained has its merits, you
may have gone a little too far here - splitting at maintainer
boundaries would have made the series quite a bit shorter I
think, but no worse to review. My ack stands in case you
decide to combine some of the patches.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.