Re: [Xen-devel] [PATCH] xsm/flask: Fix build following "xsm: correct AVC lookups for two sysctls"

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/08/17 14:17, Andrew Cooper wrote:
> avc_current_has_perm() takes 4 arguments, not 3.  Spotted by a Travis
> randconfig run which actually turned XSM on.

Sorry - I intended to add this link to the commit message.

~Andrew

https://travis-ci.org/xen-project/xen/jobs/263063220

>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> ---
>  xen/xsm/flask/hooks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index 17560b1..9114627 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -815,11 +815,11 @@ static int flask_sysctl(int cmd)
>  
>      case XEN_SYSCTL_get_cpu_levelling_caps:
>          return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
> -                                    XEN2__GET_CPU_LEVELLING_CAPS);
> +                                    XEN2__GET_CPU_LEVELLING_CAPS, NULL);
>  
>      case XEN_SYSCTL_get_cpu_featureset:
>          return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
> -                                    XEN2__GET_CPU_FEATURESET);
> +                                    XEN2__GET_CPU_FEATURESET, NULL);
>  
>      case XEN_SYSCTL_livepatch_op:
>          return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel