[Xen-devel] Question about libxc-migration-stream.pandoc

[Bruno Alvisio <bruno.alvisio@xxxxxxxxx>]

Hello,

In /docs/specs/libxc-migration-stream.pandoc "x86 HVM Guest" section states that:

"HVM\_PARAMS must precede HVM\_CONTEXT, as certain parameters can affect the validity of architectural state in the context." (line 679)

However, from the code it looks like the HVM_CONTEXT record is sent and processed before the HVM_PARAMS record:

/tools/libxc/xc_sr_save_x86_hvm.c:

static int x86_hvm_end_of_checkpoint(struct xc_sr_context *ctx)

{

    int rc;

    /* Write the TSC record. */
    rc = write_tsc_info(ctx);
    if ( rc )
        return rc;

    /* Write the HVM_CONTEXT record. */
    rc = write_hvm_context(ctx);
    if ( rc )
        return rc;
    /* Write HVM_PARAMS record contains applicable HVM params. */

    rc = write_hvm_params(ctx);

    if ( rc )
        return rc;

    return 0;
}

I wanted to confirm is this is just a typo in the documentation file or a bug on the code?

Thanks,

Bruno

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel